chore: upgrade Node.js to 22.22.0 for security fix (reown-com#5469) #920
chore: upgrade Node.js to 22.22.0 for security fix (reown-com#5469) #920Dargon789 merged 0 commit intoDargon789:fix-flag-appkitfrom
Conversation
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
⛔ Snyk checks have failed. 2 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AppKit SDK by upgrading the Node.js runtime for security and integrating full support for the TRON blockchain. It also refines wallet fetching capabilities with more granular control, improves the consistency of account and network state serialization, and addresses mobile deeplink issues for Phantom wallet on Android. Additionally, the PR includes various dependency updates and comprehensive documentation additions to streamline development and understanding of the SDK's structure and usage. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily introduces support for the TRON blockchain by adding a new TRON adapter and updating various components and configurations. It also includes a significant and beneficial refactoring to standardize account object creation around CAIP addresses, enhancing consistency across different blockchain adapters. Additionally, it addresses a security vulnerability by upgrading the Node.js version and includes several other fixes and improvements, such as better error handling for WalletConnect and improved Android deeplink handling for Phantom wallet. My review focuses on the new TRON provider implementation. The changes are well-structured and improve the codebase's maintainability and correctness.
|
@Mergifyio rebase |
☑️ Nothing to do, the required conditions are not metDetails
|
Dargon789
force-pushed
the
fix-flag-appkit
branch
from
307ad5e to
bee40f6
Compare
1 participant
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist