Skip to content

feat: expose WC relay clientId in useAppKitWallets (#5608)#972

Merged
Dargon789 merged 0 commit intoDargon789:main-authfrom
reown-com:main
Apr 9, 2026
Merged

feat: expose WC relay clientId in useAppKitWallets (#5608)#972
Dargon789 merged 0 commit intoDargon789:main-authfrom
reown-com:main

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Apr 9, 2026

CI is a bit flaky, gh runners having issues for final test

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 9, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 9, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 9, 2026

⚠️ The sha of the head commit of this PR conflicts with #421. Mergify cannot evaluate rules on this PR. Once #421 is merged or closed, Mergify will resume processing this PR. ⚠️

@Dargon789 Dargon789 self-assigned this Apr 9, 2026
@Dargon789 Dargon789 added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right question Further information is requested wontfix This will not be worked on dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 9, 2026
@Dargon789 Dargon789 enabled auto-merge (squash) April 9, 2026 00:05
@Dargon789 Dargon789 merged commit f913185 into Dargon789:main-auth Apr 9, 2026
53 of 109 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in web3-Defi-Gamefi Apr 9, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exposes the WalletConnect relay client ID (wcClientId) in the useAppKitWallets hook by sourcing it from the BlockchainApiController state. The UseAppKitWalletsReturn interface and associated tests have been updated to include this new property. A review comment correctly identifies that adding a new property to the hook's return object constitutes a new feature and suggests updating the changeset versioning from patch to minor to align with semantic versioning standards.

I am having trouble creating individual review comments. Click here to see my feedback.

.changeset/fiery-carrots-grin.md (2)

medium

Since this change introduces a new property (wcClientId) to the useAppKitWallets hook return object, it should be classified as a new feature (minor) rather than a patch according to Semantic Versioning (SemVer).

'@reown/appkit-controllers': minor

@Dargon789 Dargon789 linked an issue Apr 9, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right javascript Pull requests that update javascript code question Further information is requested wontfix This will not be worked on

Projects

Status: Done

1 participant