feat: expose WC relay clientId in useAppKitWallets (#5608)#972
feat: expose WC relay clientId in useAppKitWallets (#5608)#972Dargon789 merged 0 commit intoDargon789:main-authfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Code Review
This pull request exposes the WalletConnect relay client ID (wcClientId) in the useAppKitWallets hook by sourcing it from the BlockchainApiController state. The UseAppKitWalletsReturn interface and associated tests have been updated to include this new property. A review comment correctly identifies that adding a new property to the hook's return object constitutes a new feature and suggests updating the changeset versioning from patch to minor to align with semantic versioning standards.
I am having trouble creating individual review comments. Click here to see my feedback.
.changeset/fiery-carrots-grin.md (2)
Since this change introduces a new property (wcClientId) to the useAppKitWallets hook return object, it should be classified as a new feature (minor) rather than a patch according to Semantic Versioning (SemVer).
'@reown/appkit-controllers': minor
CI is a bit flaky, gh runners having issues for final test
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist