Conversation
…ies (#965) Add pnpm overrides for node-forge, picomatch, path-to-regexp, and fast-xml-parser. Bump happy-dom devDependency in siwx package. Co-authored-by: Sven <fr.sven.fr@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR addresses high-severity Dependabot alerts by adding pnpm overrides for vulnerable transitive dependencies and bumping a dev-only DOM emulation library in the siwx package, with corresponding lockfile updates. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The pnpm
overridesentries are using open-ended>=ranges, which can reduce build determinism; consider pinning to specific versions that resolve the alerts so dependency trees remain reproducible. - It may be helpful to add a brief inline comment near the new
overridesexplaining which dependabot alerts they address and any context for future removal or adjustment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The pnpm `overrides` entries are using open-ended `>=` ranges, which can reduce build determinism; consider pinning to specific versions that resolve the alerts so dependency trees remain reproducible.
- It may be helpful to add a brief inline comment near the new `overrides` explaining which dependabot alerts they address and any context for future removal or adjustment.
## Individual Comments
### Comment 1
<location path="package.json" line_range="117-120" />
<code_context>
"has-ansi": "<=5.0.1",
- "oxc-parser": "0.56.5"
+ "oxc-parser": "0.56.5",
+ "node-forge": ">=1.4.0",
+ "picomatch": ">=4.0.4",
+ "path-to-regexp": ">=8.4.0",
+ "fast-xml-parser": ">=5.5.6"
},
"patchedDependencies": {
</code_context>
<issue_to_address>
**🚨 issue (security):** Using open-ended `>=` ranges in overrides may reintroduce future vulnerabilities.
The existing overrides here all use upper-bounded ranges (for example `<=2.13.1`) to keep dependency resolution within a known-safe window. These new entries use unbounded `>=` constraints, so future vulnerable releases of `node-forge`, `picomatch`, `path-to-regexp`, or `fast-xml-parser` could be pulled in. Please switch to pinned or upper-bounded ranges (for example `^1.4.0` with monitoring, or `>=1.4.0 <2` / `<=x.y.z` once a safe range is known) to match the security posture of the surrounding overrides.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request adds several dependency constraints to the root package.json and updates happy-dom in the siwx package. Feedback was provided regarding the use of non-existent version numbers for node-forge, picomatch, path-to-regexp, fast-xml-parser, and happy-dom, which would cause installation failures.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
This comment was marked as low quality.
This comment was marked as low quality.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
@Mergifyio refresh |
1 similar comment
|
@Mergifyio refresh |
☑️ Command
|
✅ Pull request refreshed |
…ies (#965)
Add pnpm overrides for node-forge, picomatch, path-to-regexp, and fast-xml-parser. Bump happy-dom devDependency in siwx package.
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Summary by Sourcery
Address security alerts by overriding vulnerable transitive dependencies and updating related tooling dependencies.
Build:
Chores: