feat[infrared]: allow disabling automatic signal decoding#273
Merged
xMasterX merged 1 commit intoDarkFlippers:devfrom Jan 18, 2023
Merged
feat[infrared]: allow disabling automatic signal decoding#273xMasterX merged 1 commit intoDarkFlippers:devfrom
xMasterX merged 1 commit intoDarkFlippers:devfrom
Conversation
Member
|
Fiya! 🔥 |
|
Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app. |
Member
No, it is not needed for regular usage, normal learn captures raw data if it cannot decode it hiding it in debug is a requirement to have that functionality |
|
Ah okay, yeah that makes sense. Completely forgot that it does automatically fall back to RAW when it cannot decode it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Adds a new menu item
Lean New Remote RAWin the Infrared App, which is only visible when the debug mode is enabled in the settings. When used, automatic decoding of signals is prevented -> you always get a raw capture.Screen.Recording.2023-01-08.at.02.07.47.mov
Verification
Settings -> System -> Debug -> OFF)InfraredappLearn New Remote RAWshould be missingSettings -> System -> Debug -> ON)InfraredappLearn New Remote RAWshould be availableLearn New Remoteand verify that signals are decodedLearn New Remote RAWand verify that signals are not decodedChecklist (For Reviewer)