fix(steering): fix incorrect splice/indexOf arguments in blacklist timer cleanup #4946
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mer cleanup The `1` was incorrectly passed as the `fromIndex` parameter to `indexOf()` instead of as the `deleteCount` parameter to `splice()`. This caused two bugs: 1. `indexOf(timer, 1)` skips index 0, so timers at position 0 are never found 2. `splice(index)` without a second argument removes ALL elements from that index onward, instead of removing just the one timer This results in timer references leaking in the array and valid timers being incorrectly removed, causing memory leaks during long content steering sessions. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4944
ContentSteeringSelector._onAddBlackList()where1was passed asfromIndextoindexOf()instead of asdeleteCounttosplice()blacklistResetTimeout.splice(blacklistResetTimeout.indexOf(timer, 1))— skips index 0 and removes all elements from found indexblacklistResetTimeout.splice(blacklistResetTimeout.indexOf(timer), 1)— correctly finds timer at any position and removes only that one entryTest plan
blacklistResetTimeoutarray does not grow unboundedly during long sessions🤖 Generated with Claude Code