fix(mss): prevent crash when all DVR segments are removed #4947
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The while loop that removes segments prior to the DVR availability start time did not check if the segments array became empty after each splice. When all segments fall before availabilityStartTime, the array is fully emptied and accessing segments[0] throws a TypeError. Add array length checks both in the loop condition and after the loop before accessing segments[0] for the DVR range update. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4945
segments.length > 0guard to the DVR segment cleanup loop condition inMssFragmentMoofProcessorbreakaftersplice()when the segments array becomes emptysegmentsWithout this fix, a
TypeError: Cannot read properties of undefined (reading 't')crash occurs when all segments fall beforeavailabilityStartTimein live MSS streams withtimeShiftBufferDepth.Test plan
timeShiftBufferDepthand verify no crash on segment cleanuptimeShiftBufferDepth, resume, and verify graceful handling🤖 Generated with Claude Code