Add a limitBitrateByPortalMinimum setting to prevent limiting too much #4950
+64
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the setting
limitBitrateByPortalto prevent the player streaming a representation with a resolution that would be too big for the size of the video element. But we have a player that can be resized from quite small to full screen, and we'd like to have some minimum on this setting so we don't fill up the buffer with the very worst resolution in our ABR ladder before maximising.So,
limitBitrateByPortalMinimumtakes a value in kbps and preventslimitBitrateByPortalfrom excluding any representations below this bitrate. The default is 0kbps so all representations can be limited.