Update sharing APIs to match server#2259
Update sharing APIs to match server#2259api-clients-generation-pipeline[bot] merged 1 commit intomasterfrom
Conversation
| end | ||
|
|
||
| if attributes.key?(:'embeddable_domains') | ||
| if (value = attributes[:'embeddable_domains']).is_a?(Array) |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider using Array() to ensure the type is that of an array (...read more)
The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.
The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.
By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.
Datadog ReportBranch report: ✅ 0 Failed, 1165 Passed, 1820 Skipped, 1m 53.03s Total Time |
f09dfa9 to
b25efd3
Compare
89a6f9d to
3bada28
Compare
3bada28 to
3dcee13
Compare
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> f61a03b
See DataDog/datadog-api-spec#3565
Test branch datadog-api-spec/test/michelle.lee/fix-shareddash