feat: Support container ID field (dogstatsd 1.2)#250
Merged
ahmed-mez merged 6 commits intoDataDog:masterfrom Feb 4, 2022
Merged
feat: Support container ID field (dogstatsd 1.2)#250ahmed-mez merged 6 commits intoDataDog:masterfrom
ahmed-mez merged 6 commits intoDataDog:masterfrom
Conversation
9 tasks
hush-hush
suggested changes
Jan 26, 2022
Member
hush-hush
left a comment
There was a problem hiding this comment.
I added a few comments. We should wait on the final decision between tags and new field in dogstatsd protocol before going further.
hush-hush
suggested changes
Jan 31, 2022
hush-hush
suggested changes
Feb 1, 2022
Member
hush-hush
left a comment
There was a problem hiding this comment.
I think it's almost good to go.
hush-hush
suggested changes
Feb 2, 2022
Contributor
Author
|
Thank you for the review @hush-hush ! I'd like to get 👀 on the Agent PR before merging this one. PTAL when you get a chance! DataDog/datadog-agent#10659 |
vickenty
approved these changes
Feb 4, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR does the following
c:<id>field holding the container ID so the agent can attach container tags.Brief explanation of how the new container field is handled
DD_ENTITY_IDis set, we ignore the container fieldDD_ENTITY_IDis not set andDD_ORIGIN_DETECTION_ENABLEDis not explicitly set tofalseor theWithoutOriginDetection()is not invoked, we try to get the app container ID by parsing/proc/self/cgroup. In case of success, the container field in will be set to .Motivation
dd.internal.entity_idis to avoid parsing the value and guess the prefix on the agent side (avoid costly operations in the hot path)Notes