Skip to content

Add CMP_WILDCARD string comparator for ? and * pattern matching#52

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
natipirati/add-wild-card-matcher
Mar 20, 2026
Merged

Add CMP_WILDCARD string comparator for ? and * pattern matching#52
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
natipirati/add-wild-card-matcher

Conversation

@natitsechanski
Copy link
Collaborator

  • Add CMP_WILDCARD string comparator supporting ? (single char) and * (any chars) wildcard matching
  • Iterative implementation in C runtime — no recursion, safe on pathological input
  • Wired across FlatBuffers schema, C runtime, generated headers, Go schema, and JSON schema
  • Unit tests covering NULL handling, ?, *, mixed patterns, RFC-style paths, and backtracking edge cases

Test plan

  • make -C c test — all 55 tests pass
  • Coverage unchanged or improved on /work/c/src

@natitsechanski natitsechanski requested a review from a team as a code owner March 20, 2026 01:15
@datadog-prod-us1-5

This comment has been minimized.

Copy link
Contributor

@annacai21 annacai21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update arguments.go so wildcard patterns in the args use CmpTypeSTRCMP_WILDCARD like the commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants