Add integration test for case apms19196#8438
Merged
anna-git merged 2 commits intoApr 10, 2026
Merged
Conversation
anna-git
force-pushed
the
anna/add-integration-apms19196
branch
from
4edd0a3 to
f3d6437
Compare
anna-git
force-pushed
the
anna/add-integration-apms19196
branch
from
f3d6437 to
86b18c5
Compare
Contributor
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 3 occurrences of : + },
+ {
+ TraceId: Id_1,
+ SpanId: Id_62,
+ Name: trace.annotation,
+ Resource: ExtremeExceptionHandling.DeepNestedExceptionHandlingSync,
+ Service: Samples.TraceAnnotations,
+ ParentId: Id_2,
+ Tags: {
+ component: trace,
+ env: integration_tests,
+ language: dotnet,
+ version: 1.0.0
+ }
3 occurrences of : + },
+ {
+ TraceId: Id_1,
+ SpanId: Id_62,
+ Name: trace.annotation,
+ Resource: ExtremeExceptionHandling.DeepNestedExceptionHandlingSync,
+ Service: Samples.TraceAnnotations.VersionMismatch.AfterFeature,
+ ParentId: Id_2,
+ Tags: {
+ component: trace,
+ env: integration_tests,
+ language: dotnet,
+ version: 1.0.0
+ }
3 occurrences of : + },
+ {
+ TraceId: Id_1,
+ SpanId: Id_62,
+ Name: trace.annotation,
+ Resource: ExtremeExceptionHandling.DeepNestedExceptionHandlingSync,
+ Service: Samples.TraceAnnotations.VersionMismatch.BeforeFeature,
+ ParentId: Id_2,
+ Tags: {
+ component: trace,
+ env: integration_tests,
+ language: dotnet,
+ version: 1.0.0
+ }
|
anna-git
changed the title
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8438) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (72ms) : 69, 75
master - mean (72ms) : 69, 75
section Bailout
This PR (8438) - mean (76ms) : 74, 79
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8438) - mean (1,069ms) : 1023, 1115
master - mean (1,071ms) : 1008, 1134
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (112ms) : 108, 116
master - mean (112ms) : 109, 115
section Bailout
This PR (8438) - mean (113ms) : 111, 116
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8438) - mean (782ms) : 756, 808
master - mean (776ms) : 756, 796
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (99ms) : 96, 101
master - mean (99ms) : 95, 103
section Bailout
This PR (8438) - mean (100ms) : 98, 103
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8438) - mean (930ms) : 898, 963
master - mean (927ms) : 893, 961
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (98ms) : 95, 101
master - mean (97ms) : 94, 100
section Bailout
This PR (8438) - mean (99ms) : 96, 102
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8438) - mean (816ms) : 782, 850
master - mean (811ms) : 783, 840
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (193ms) : 188, 198
master - mean (194ms) : 191, 197
section Bailout
This PR (8438) - mean (196ms) : 194, 199
master - mean (198ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (8438) - mean (1,148ms) : 1105, 1190
master - mean (1,155ms) : 1094, 1216
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (276ms) : 272, 280
master - mean (279ms) : 275, 283
section Bailout
This PR (8438) - mean (277ms) : 273, 281
master - mean (279ms) : 276, 282
section CallTarget+Inlining+NGEN
This PR (8438) - mean (928ms) : 904, 951
master - mean (927ms) : 905, 949
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (270ms) : 266, 274
master - mean (271ms) : 267, 275
section Bailout
This PR (8438) - mean (271ms) : 266, 275
master - mean (271ms) : 268, 273
section CallTarget+Inlining+NGEN
This PR (8438) - mean (1,143ms) : 1098, 1189
master - mean (1,142ms) : 1097, 1186
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8438) - mean (269ms) : 265, 273
master - mean (269ms) : 266, 273
section Bailout
This PR (8438) - mean (268ms) : 265, 271
master - mean (269ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8438) - mean (1,024ms) : 981, 1066
master - mean (1,024ms) : 982, 1066
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anna-git
changed the base branch from
master
to
steven/attempt-fix-invalid-program-exception
anna-git
merged commit 4134da7
into
steven/attempt-fix-invalid-program-exception
136 of 140 checks passed
bouwkast
pushed a commit
that referenced
this pull request
Apr 17, 2026
## Summary of changes This reproduces the crash [described in this README](https://github.com/DataDog/dd-trace-dotnet/blob/82cc4cf0e29478fd2fdc41afdf764a2abf662199/repro/APMS-19196/README.md) on linux x64 arch. Aim is to merge to #8428 First tested it's crashing on master <img width="2830" height="851" alt="image" src="https://github.com/user-attachments/assets/96e882fa-308e-44b6-8116-c93c7d5b7bb2" /> ## Reason for change ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> <!--⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This reproduces the crash described in this README on linux x64 arch.
Aim is to merge to #8428
First tested it's crashing on master
Reason for change
Implementation details
Test coverage
Other details