-
Notifications
You must be signed in to change notification settings - Fork 319
Stream the SymDB serialization and compression #9642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (314.705 µs) : 292, 337
. : milestone, 315,
basic (275.256 µs) : 269, 281
. : milestone, 275,
loop (8.952 ms) : 8948, 8956
. : milestone, 8952,
section candidate
noprobe (321.569 µs) : 290, 353
. : milestone, 322,
basic (278.459 µs) : 273, 284
. : milestone, 278,
loop (8.96 ms) : 8955, 8965
. : milestone, 8960,
|
|
🎯 Code Coverage 🔗 Commit SHA: e4b9cf7 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018907
Total [baseline] (10.712 s) : 0, 10711957
Agent [candidate] (1.02 s) : 0, 1020053
Total [candidate] (10.625 s) : 0, 10625310
section appsec
Agent [baseline] (1.2 s) : 0, 1200175
Total [baseline] (11.127 s) : 0, 11126593
Agent [candidate] (1.193 s) : 0, 1193179
Total [candidate] (11.101 s) : 0, 11101124
section iast
Agent [baseline] (1.149 s) : 0, 1149481
Total [baseline] (10.982 s) : 0, 10981884
Agent [candidate] (1.15 s) : 0, 1150006
Total [candidate] (11.069 s) : 0, 11068578
section profiling
Agent [baseline] (1.164 s) : 0, 1163648
Total [baseline] (11.093 s) : 0, 11093000
Agent [candidate] (1.161 s) : 0, 1160613
Total [candidate] (11.058 s) : 0, 11057534
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (695.08 ms) : 0, 695080
BytebuddyAgent [candidate] (694.782 ms) : 0, 694782
GlobalTracer [baseline] (243.779 ms) : 0, 243779
GlobalTracer [candidate] (243.559 ms) : 0, 243559
AppSec [baseline] (31.499 ms) : 0, 31499
AppSec [candidate] (31.436 ms) : 0, 31436
Debugger [baseline] (6.412 ms) : 0, 6412
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (689.591 µs) : 0, 690
Remote Config [candidate] (678.587 µs) : 0, 679
Telemetry [baseline] (9.148 ms) : 0, 9148
Telemetry [candidate] (9.034 ms) : 0, 9034
Flare Poller [baseline] (9.56 ms) : 0, 9560
Flare Poller [candidate] (11.539 ms) : 0, 11539
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (722.461 ms) : 0, 722461
BytebuddyAgent [candidate] (716.861 ms) : 0, 716861
GlobalTracer [baseline] (237.197 ms) : 0, 237197
GlobalTracer [candidate] (236.009 ms) : 0, 236009
AppSec [baseline] (173.381 ms) : 0, 173381
AppSec [candidate] (173.572 ms) : 0, 173572
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (646.659 µs) : 0, 647
Remote Config [candidate] (630.643 µs) : 0, 631
Telemetry [baseline] (8.471 ms) : 0, 8471
Telemetry [candidate] (8.463 ms) : 0, 8463
Flare Poller [baseline] (4.037 ms) : 0, 4037
Flare Poller [candidate] (4.028 ms) : 0, 4028
IAST [baseline] (25.165 ms) : 0, 25165
IAST [candidate] (24.963 ms) : 0, 24963
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (813.654 ms) : 0, 813654
BytebuddyAgent [candidate] (814.435 ms) : 0, 814435
GlobalTracer [baseline] (233.153 ms) : 0, 233153
GlobalTracer [candidate] (233.402 ms) : 0, 233402
AppSec [baseline] (34.479 ms) : 0, 34479
AppSec [candidate] (34.084 ms) : 0, 34084
Debugger [baseline] (6.025 ms) : 0, 6025
Debugger [candidate] (6.052 ms) : 0, 6052
Remote Config [baseline] (596.239 µs) : 0, 596
Remote Config [candidate] (577.874 µs) : 0, 578
Telemetry [baseline] (8.069 ms) : 0, 8069
Telemetry [candidate] (8.144 ms) : 0, 8144
Flare Poller [baseline] (4.243 ms) : 0, 4243
Flare Poller [candidate] (4.234 ms) : 0, 4234
IAST [baseline] (26.355 ms) : 0, 26355
IAST [candidate] (26.334 ms) : 0, 26334
section profiling
ProfilingAgent [baseline] (102.774 ms) : 0, 102774
ProfilingAgent [candidate] (102.616 ms) : 0, 102616
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (727.217 ms) : 0, 727217
BytebuddyAgent [candidate] (723.485 ms) : 0, 723485
GlobalTracer [baseline] (220.159 ms) : 0, 220159
GlobalTracer [candidate] (220.474 ms) : 0, 220474
AppSec [baseline] (31.641 ms) : 0, 31641
AppSec [candidate] (31.66 ms) : 0, 31660
Debugger [baseline] (7.385 ms) : 0, 7385
Debugger [candidate] (7.356 ms) : 0, 7356
Remote Config [baseline] (752.559 µs) : 0, 753
Remote Config [candidate] (733.181 µs) : 0, 733
Telemetry [baseline] (15.298 ms) : 0, 15298
Telemetry [candidate] (15.555 ms) : 0, 15555
Flare Poller [baseline] (4.157 ms) : 0, 4157
Flare Poller [candidate] (4.212 ms) : 0, 4212
Profiling [baseline] (103.489 ms) : 0, 103489
Profiling [candidate] (103.807 ms) : 0, 103807
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016382
Total [baseline] (8.678 s) : 0, 8678296
Agent [candidate] (1.017 s) : 0, 1017255
Total [candidate] (8.634 s) : 0, 8634440
section iast
Agent [baseline] (1.158 s) : 0, 1157684
Total [baseline] (9.281 s) : 0, 9280609
Agent [candidate] (1.152 s) : 0, 1152490
Total [candidate] (9.329 s) : 0, 9329322
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (691.914 ms) : 0, 691914
BytebuddyAgent [candidate] (692.605 ms) : 0, 692605
GlobalTracer [baseline] (243.021 ms) : 0, 243021
GlobalTracer [candidate] (243.68 ms) : 0, 243680
AppSec [baseline] (31.543 ms) : 0, 31543
AppSec [candidate] (31.243 ms) : 0, 31243
Debugger [baseline] (6.357 ms) : 0, 6357
Debugger [candidate] (6.365 ms) : 0, 6365
Remote Config [baseline] (687.745 µs) : 0, 688
Remote Config [candidate] (671.857 µs) : 0, 672
Telemetry [baseline] (9.096 ms) : 0, 9096
Telemetry [candidate] (9.102 ms) : 0, 9102
Flare Poller [baseline] (11.143 ms) : 0, 11143
Flare Poller [candidate] (11.019 ms) : 0, 11019
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (820.108 ms) : 0, 820108
BytebuddyAgent [candidate] (816.943 ms) : 0, 816943
GlobalTracer [baseline] (234.38 ms) : 0, 234380
GlobalTracer [candidate] (232.485 ms) : 0, 232485
IAST [baseline] (26.69 ms) : 0, 26690
IAST [candidate] (26.667 ms) : 0, 26667
AppSec [baseline] (34.366 ms) : 0, 34366
AppSec [candidate] (34.425 ms) : 0, 34425
Debugger [baseline] (6.118 ms) : 0, 6118
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (594.268 µs) : 0, 594
Remote Config [candidate] (585.894 µs) : 0, 586
Telemetry [baseline] (8.338 ms) : 0, 8338
Telemetry [candidate] (8.271 ms) : 0, 8271
Flare Poller [baseline] (4.261 ms) : 0, 4261
Flare Poller [candidate] (4.248 ms) : 0, 4248
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section baseline
no_agent (36.122 ms) : 35827, 36418
. : milestone, 36122,
appsec (51.608 ms) : 51150, 52065
. : milestone, 51608,
code_origins (42.574 ms) : 42223, 42924
. : milestone, 42574,
iast (45.285 ms) : 44906, 45663
. : milestone, 45285,
profiling (48.947 ms) : 48505, 49389
. : milestone, 48947,
tracing (44.543 ms) : 44163, 44924
. : milestone, 44543,
section candidate
no_agent (35.922 ms) : 35634, 36209
. : milestone, 35922,
appsec (49.662 ms) : 49221, 50103
. : milestone, 49662,
code_origins (44.805 ms) : 44425, 45184
. : milestone, 44805,
iast (45.784 ms) : 45380, 46188
. : milestone, 45784,
profiling (49.491 ms) : 49062, 49921
. : milestone, 49491,
tracing (46.64 ms) : 46236, 47044
. : milestone, 46640,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section baseline
no_agent (4.333 ms) : 4283, 4383
. : milestone, 4333,
iast (10.168 ms) : 9994, 10342
. : milestone, 10168,
iast_FULL (14.564 ms) : 14273, 14855
. : milestone, 14564,
iast_GLOBAL (10.204 ms) : 10027, 10382
. : milestone, 10204,
profiling (9.386 ms) : 9241, 9531
. : milestone, 9386,
tracing (7.954 ms) : 7840, 8069
. : milestone, 7954,
section candidate
no_agent (4.506 ms) : 4456, 4557
. : milestone, 4506,
iast (9.938 ms) : 9770, 10106
. : milestone, 9938,
iast_FULL (15.16 ms) : 14861, 15458
. : milestone, 15160,
iast_GLOBAL (10.953 ms) : 10759, 11147
. : milestone, 10953,
profiling (8.979 ms) : 8831, 9126
. : milestone, 8979,
tracing (7.767 ms) : 7644, 7889
. : milestone, 7767,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.706 ms) : 3489, 3924
. : milestone, 3706,
iast (2.224 ms) : 2159, 2288
. : milestone, 2224,
iast_GLOBAL (2.247 ms) : 2183, 2312
. : milestone, 2247,
profiling (2.054 ms) : 2003, 2106
. : milestone, 2054,
tracing (2.025 ms) : 1975, 2074
. : milestone, 2025,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.655 ms) : 3442, 3869
. : milestone, 3655,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.074 ms) : 2021, 2127
. : milestone, 2074,
tracing (2.026 ms) : 1976, 2076
. : milestone, 2026,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e4b9cf7516, baseline=1.54.0-SNAPSHOT~836ba8d864
dateFormat X
axisFormat %s
section baseline
no_agent (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
appsec (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
iast (18.461 s) : 18461000, 18461000
. : milestone, 18461000,
iast_GLOBAL (18.228 s) : 18228000, 18228000
. : milestone, 18228000,
profiling (15.486 s) : 15486000, 15486000
. : milestone, 15486000,
tracing (15.259 s) : 15259000, 15259000
. : milestone, 15259000,
section candidate
no_agent (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
appsec (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
iast (18.594 s) : 18594000, 18594000
. : milestone, 18594000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
tracing (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
|
Current SymDB serialization use intermediate full large buffer for every intermediate operation: - serializing to string - converting to UTF-8 byte array - compressing with gzip every operation imply potentially large buffer (several 10MBs). On constraint heaps it can lead to OOME. we now stream this process using outputstream, buffered sink for serialization so we have less large buffers in flight.
519e8c2 to
e4b9cf7
Compare
What Does This Do
Current SymDB serialization use intermediate full large buffer for every intermediate operation:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4545