Fix tag uploads for junit test #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxch-
reviewed
Jul 12, 2022
alxch-
left a comment
alxch-
left a comment
There was a problem hiding this comment.
I guess the README should be updated too to reflect that change?
Contributor
Author
Why? The interface stays the same the user still needs to do: - uses: datadog/junit-upload-github-action@v1
with:
api-key: ${{secrets.DD_API_KEY}}
datadog-site: datad0g.com
logs: "true"
files: ./ci/fixtures/
service: junit-upload-github-action
env: ci
tags: "foo:bar,alpha:bravo"We only changed inside the action how we pass the input tags from the CLI to the env vars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue reported in #10 that incorrectly sets the tags for the tests. Using the env var
DD_TAGSinstead of the terminal option--tagssaves us having to parse the input.