Skip to content

Conversation

@juan-fernandez
Copy link
Contributor

@juan-fernandez juan-fernandez commented May 28, 2024

DataDog/datadog-ci#1304 is caused by bad handling of glob patterns in datadog-ci. We're fixing this in DataDog/datadog-ci#1315, but I want to be able to test this here.

Changes

  • Run tests once a day.
  • Run tests for different versions of node.
  • Check that junit reports are actually correctly uploaded.
  • Update default value of node from 16 to 20.
  • Update actions/checkout and actions/setup-node to v4
  • Use npx instead of globally installing the package: it should be faster.
  • Used glob patterns in the test.

<!-- Python / unittest-xml-report -->
<testsuite errors="0" failures="1" file="api/tests_unittest.py" name="api.tests_unittest.TestStringMethods-20200211105522" skipped="1" tests="5" time="0.007" timestamp="2020-02-11T10:55:22">
<testcase classname="api.tests_unittest.TestStringMethods" file="api/tests_unittest.py" line="8" name="test_isupper" time="0.000" timestamp="2020-02-11T10:55:22">
<testsuite errors="0" failures="1" file="api/tests_unittest.py" name="api.tests_unittest.TestStringMethods-20200211105522" skipped="1" tests="5" time="0.007">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed timestamps from this report, otherwise it wouldn't get processed by our backend

@juan-fernandez juan-fernandez changed the title Better tests Improve testing of the action and update dependencies May 28, 2024
@juan-fernandez juan-fernandez marked this pull request as ready for review May 28, 2024 10:46
@juan-fernandez juan-fernandez requested a review from a team as a code owner May 28, 2024 10:46
@juan-fernandez juan-fernandez merged commit 79fc8b0 into main May 28, 2024
@juan-fernandez juan-fernandez deleted the juan-fernandez/testing-new-version branch May 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants