Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@mackjmr
Copy link
Member

@mackjmr mackjmr commented May 27, 2025

What does this PR do?

This PR adds support for host aliases. Users can now set host aliases by setting resource attribute datadog.host.use_as_metadata to true and datadog.host.aliases as a slice of host aliases.

Motivation

@mackjmr mackjmr marked this pull request as ready for review May 27, 2025 11:09
@mackjmr mackjmr requested a review from a team as a code owner May 27, 2025 11:09
@mackjmr mackjmr requested a review from ankitpatel96 May 27, 2025 11:09
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (60799bb) to head (bf86cf0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   81.31%   81.44%   +0.13%     
==========================================
  Files          49       49              
  Lines        3704     3730      +26     
==========================================
+ Hits         3012     3038      +26     
  Misses        610      610              
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix tests, otherwise LGTM

@mackjmr mackjmr merged commit 76611c3 into main May 28, 2025
6 checks passed
@mackjmr mackjmr deleted the mackjmr/support-host-aliases branch May 28, 2025 14:56
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
jackgopack4 added a commit to DataDog/datadog-agent that referenced this pull request Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants