This repository was archived by the owner on Sep 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for host aliases #661
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 81.31% 81.44% +0.13%
==========================================
Files 49 49
Lines 3704 3730 +26
==========================================
+ Hits 3012 3038 +26
Misses 610 610
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
reviewed
May 27, 2025
songy23
approved these changes
May 28, 2025
Member
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix tests, otherwise LGTM
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
jackgopack4
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 13, 2025
…go#661) commit 76611c3851cd88faca773c2295f16d571ea7ae32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for host aliases. Users can now set host aliases by setting resource attribute
datadog.host.use_as_metadatato true anddatadog.host.aliasesas a slice of host aliases.Motivation