Add detailed debug information when target_tables is empty#11
Conversation
Contributor
|
I welcome the addition of detailed logs, as they are helpful in the investigation. However, it seems a bit tedious to add logs each time they are needed. For example, I thought the following gem could be introduced to I will discuss this a bit later on my end. |
genya0407
reviewed
Jul 19, 2024
Co-authored-by: Yusuke Sangenya <longinus.eva@gmail.com>
genya0407
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds detailed debug information to the clean method of Cleaner to log the context when target_tables is empty. the following information will be logged when target_tables is empty:
If you find this change to be excessive, it is perfectly fine not to merge it.
Other Information
Checklist