Skip to content

Add detailed debug information when target_tables is empty#11

Merged
genya0407 merged 2 commits intotrunkfrom
unknown repository
Jul 19, 2024
Merged

Add detailed debug information when target_tables is empty#11
genya0407 merged 2 commits intotrunkfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 18, 2024

Summary

This pull request adds detailed debug information to the clean method of Cleaner to log the context when target_tables is empty. the following information will be logged when target_tables is empty:

  • The target tables (tables)
  • The except tables (@except_tables)
  • All tables in the database (all_tables)

If you find this change to be excessive, it is perfectly fine not to merge it.

Other Information

Checklist

@genya0407
Copy link
Contributor

I welcome the addition of detailed logs, as they are helpful in the investigation. However, it seems a bit tedious to add logs each time they are needed.

For example, I thought the following gem could be introduced to mysql_rewinder and your project to make the log output more comprehensive.
https://github.com/pboling/debug_logging/tree/v3.1.9

I will discuss this a bit later on my end.

Co-authored-by: Yusuke Sangenya <longinus.eva@gmail.com>
@genya0407 genya0407 merged commit 16a9026 into DeNA:trunk Jul 19, 2024
@ghost ghost deleted the update-log-message branch July 19, 2024 03:27
@genya0407 genya0407 mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant