Remove prerelease refs and cleanup workflows#203
Merged
DecSmith42 merged 3 commits intomainfrom Jun 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes prerelease flags and cleans up outdated workflow definitions, while standardizing API annotations and usings across projects.
- Eliminates
--prereleasereferences in both GitHub and Azure DevOps workflow writers. - Deletes obsolete
.githuband.devopsYAML workflows for manual parameters and custom artifacts. - Adds
[PublicAPI]annotations and tidies up global usings in various modules.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| _atom/_usings.cs | Removed unused global using DecSm.Atom.BuildInfo |
| _atom/Build.cs | Removed the Test_BuildWithCustomArtifacts workflow block |
| DecSm.Atom.Module.GithubWorkflows/_usings.cs | Added global using System.Globalization |
| DecSm.Atom.Module.GithubWorkflows/Generation/GithubWorkflowWriter.cs | Dropped --prerelease flag and removed the corresponding TODO |
| DecSm.Atom.Module.GithubWorkflows/Expressions.cs | Added [PublicAPI] to expressions and removed obsolete usings |
| DecSm.Atom.Module.GithubWorkflows.Tests/Workflows/GithubIfBuild.cs | Introduced #pragma warning disable CA1822 for test class |
| DecSm.Atom.Module.DevopsWorkflows/Generation/DevopsWorkflowWriter.cs | Dropped --prerelease flag in DevOps script step |
| DecSm.Atom.Analyzers/Resources.resx | Updated XML formatting and added ReSharper disable directive |
| DecSm.Atom.Analyzers/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParamCodeFixProvider.cs | Reformatted method signature to static async with multi-line args |
| DecSm.Atom.Analyzers/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParamAnalyzer.cs | Made AnalyzeOperation static |
| DecSm.Atom.Analyzers.Tests/ExtendedCodeFixVerifier.cs | Added JetBrains Annotations import and [PublicAPI] to helper |
| DecSm.Atom.Analyzers.Tests/ExtendedAnalyzerVerifier.cs | Added JetBrains Annotations import and [PublicAPI] to helper |
| DecSm.Atom.Analyzers.Sample/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParam.cs | Added JetBrains Annotations import and [PublicAPI] to interface |
| .github/workflows/Test_ManualParams.yml | Removed obsolete workflow file |
| .github/workflows/Test_BuildWithCustomArtifacts.yml | Removed obsolete workflow file |
| .devops/workflows/Test_ManualParams.yml | Removed obsolete workflow file |
| .devops/workflows/Test_BuildWithCustomArtifacts.yml | Removed obsolete workflow file |
Comments suppressed due to low confidence (2)
DecSm.Atom.Module.GithubWorkflows/Expressions.cs:1
- The
[PublicAPI]attribute is used throughout this file but the JetBrains.Annotations namespace isn't imported. Addusing JetBrains.Annotations;at the top to ensure the attributes resolve correctly.
namespace DecSm.Atom.Module.GithubWorkflows;
DecSm.Atom.Module.GithubWorkflows.Tests/Workflows/GithubIfBuild.cs:1
- [nitpick] Consider adding a matching
#pragma warning restore CA1822after the class definition to limit the scope of this suppression and avoid hiding other unintended warnings.
#pragma warning disable CA1822
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.