Merged
Conversation
Added `NoneAll` option to `GithubTokenPermissionsOption` to specify no permissions for all fields. Updated logic in `GithubWorkflowWriter` to handle the new `NoneAll` option. Removed unused permissions such as `ArtifactMetadata` and `Models` to simplify the codebase. Extended `WorkflowTargetDefinition` to support custom token permission options.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances GitHub workflow security by introducing explicit "none" permissions as the default configuration. The changes implement a new NoneAll static option that sets all GitHub token permissions to none, removes obsolete permission types that are no longer supported by GitHub Actions, and provides a utility method for easier permission configuration at the target level.
- Introduces
GithubTokenPermissionsOption.NoneAllfor explicit none permissions with shorthand YAML syntaxpermissions: { } - Removes obsolete
artifact-metadataandmodelspermissions from the permissions model - Adds
WithGithubTokenPermissionsextension method for target-level permission configuration
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
_atom/Build.cs |
Applies NoneAll permissions option to Validate and Build workflows, establishing secure-by-default permission model |
DecSm.Atom.Module.GithubWorkflows/Generation/Options/GithubTokenPermissionsOption.cs |
Adds NoneAll static option, removes obsolete ArtifactMetadata and Models properties, updates ReadAll and WriteAll to exclude removed permissions |
DecSm.Atom.Module.GithubWorkflows/Generation/GithubWorkflowWriter.cs |
Implements YAML generation for NoneAll option to output permissions: { } shorthand |
DecSm.Atom.Module.GithubWorkflows/Extensions.cs |
Adds WithGithubTokenPermissions extension method for applying permission options to workflow target definitions |
.github/workflows/Validate.yml |
Adds explicit permissions: { } declaration, generated from the updated workflow definition |
.github/workflows/Build.yml |
Adds explicit permissions: { } declaration at workflow level while maintaining job-specific permissions for PushToRelease |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DecSm.Atom.Module.GithubWorkflows/Generation/Options/GithubTokenPermissionsOption.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new default GitHub workflow permissions configuration that sets permissions to "none" by default, both in workflow YAML files and in the code that generates them. Additionally, it removes support for the obsolete
artifact-metadataandmodelspermissions, and provides a new utility for applying the "none" permissions option in workflow definitions.Key changes:
Default Permissions Handling:
permissions: { }to.github/workflows/Build.ymland.github/workflows/Validate.ymlto explicitly set default permissions to none in these workflows. [1] [2]GithubTokenPermissionsOption.NoneAll, a static option that sets all permissions toNone, and applied it to workflow definitions in_atom/Build.cs. [1] [2] [3]permissions: { }whenNoneAllis selected.Permissions Option Refactoring:
artifact-metadataandmodelsproperties fromGithubTokenPermissionsOptionand their usage throughout the codebase. [1] [2] [3] [4]API Improvements:
WithGithubTokenPermissionsfor easier application of permissions options to workflow target definitions.