Skip to content

Add GameClub BSC addresses for users/new addresses tracking#6343

Open
ruddhks552 wants to merge 2 commits intoDefiLlama:masterfrom
ruddhks552:ruddhks552-patch-4
Open

Add GameClub BSC addresses for users/new addresses tracking#6343
ruddhks552 wants to merge 2 commits intoDefiLlama:masterfrom
ruddhks552:ruddhks552-patch-4

Conversation

@ruddhks552
Copy link
Copy Markdown
Contributor

…or users tracking

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a tvl adapter please submit the PR here.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  3. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data4.ts, you can edit it there and put up a PR
  4. Do not edit/push package.json/package-lock.json file as part of your changes
  5. No need to go to our discord/other channel and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Warning

Rate limit exceeded

@ruddhks552 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 5 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 5 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7b42b463-469f-410f-a178-80011751f28a

📥 Commits

Reviewing files that changed from the base of the PR and between 4f6a0a1 and 26c504f.

📒 Files selected for processing (1)
  • users/routers/routerAddresses.ts

Walkthrough

A new ProtocolAddresses entry for GameClub (id: "7624") was added to the router addresses export, including three BSC blockchain addresses for factory/proxy, exchange, and deposit router contracts. The entry follows the existing array structure with no modifications to control flow or other entries.

Changes

Cohort / File(s) Summary
Router Address Configuration
users/routers/routerAddresses.ts
Added a new ProtocolAddresses entry for GameClub with BSC network addresses (factory/proxy, exchange, and deposit router contracts).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure without filling in any protocol-specific information; all fields remain empty. Fill in the protocol form fields with GameClub details (name, chain, addresses, website, description, etc.) or replace with a brief explanation of the changes made.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add GameClub BSC addresses for users/new addresses tracking' is fully related to the main change, which adds GameClub BSC addresses to the protocol addresses list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Breakdown Methodology Check ✅ Passed Pull request modifies user router addresses configuration file (routerAddresses.ts), not a fees adapter implementation. The custom check about breakdown methodology is not applicable to router address changes.
Income Statement Compliance ✅ Passed PR adds GameClub protocol entry to routerAddresses.ts; Income Statement Compliance check applies only to fees adapters with financial metrics, not address registration.
Version 2 Required ✅ Passed PR adds GameClub protocol entry to existing v1 users/routers adapter, which is explicitly allowed per check requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…es - use only DEPOSIT_ROUTER for user tracking

Removed unused wallet addresses from GameClub.
@bheluga bheluga self-assigned this Apr 6, 2026
Copy link
Copy Markdown
Member

@bheluga bheluga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruddhks552 thanks for the PR.
Can you use trade contract instead, which would give clear picture of active users, txns count etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants