Update Strike Finance fees adapter to v2#6402
Conversation
- Switch API endpoint from beta to app.strikefinance.org - Return fees in USD instead of per-asset ADA/SNEK balances - Simplify to single totalFees field covering v1 + v2 fees - Update methodology descriptions
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe Strike Finance fees adapter's Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The strike-finance adapter exports: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@fees/strike-finance/index.ts`:
- Around line 26-30: Add a breakdownMethodology object alongside the existing
methodology in the fees adapter that documents each fee source label used (e.g.,
"Fees", "Revenue", "HoldersRevenue") with short descriptions; update the file's
methodology block (the existing methodology object in this diff) to include
breakdownMethodology: { Fees: "Description of trading fee source", Revenue:
"Description of revenue metric", HoldersRevenue: "Description of how fees are
allocated to $STRIKE holders" } and ensure any .add() calls in this module use
those explicit labels to match the breakdown.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: dfdb523c-4a69-4756-9e88-8b1afe0d57f6
📒 Files selected for processing (1)
fees/strike-finance/index.ts
|
The strike-finance adapter exports: |
|
The strike-finance adapter exports: |
Summary
Test