move solana dex trades to factory

[bheluga]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@bheluga has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 58 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 58 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 84aafb0e-0c55-40ca-85f2-3e7865203211

📥 Commits

Reviewing files that changed from the base of the PR and between 7256d06 and 8642e16.

📒 Files selected for processing (1)

• dexs/zerofi/index.ts

Walkthrough

Three Solana DEX adapter implementations (aquifer, goonfi, launchlab) are removed. The Dune Solana DEX factory configuration is refactored to map DEX names to objects containing both a project identifier and start date, while new entries for the removed adapters and an additional zerofi DEX are added.

Changes

Cohort / File(s)	Summary
Removed Adapters dexs/aquifer/index.ts, dexs/goonfi/index.ts, dexs/launchlab/index.ts	Deleted three Solana DEX adapter implementations that queried Dune SQL for daily volumes. Each adapter enforced indexing delays and executed trades queries against dex_solana.trades for their respective projects.
Factory Configuration factory/duneSolanaDex.ts	Restructured dexsConfigs from mapping DEX names to start dates into a structure mapping names to objects with project and start properties. Updated the construction loop to destructure and pass the project identifier. Added new entries for aquifer, goonfi, launchlab (with raydium_launchlab as project), and zerofi.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

dexs

🚥 Pre-merge checks | ✅ 2 | ❌ 4

❌ Failed checks (3 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'move solana dex trades to factory' is descriptive and clearly summarizes the main change, but does not follow the required format of '[type] protocol-name - description'.	Reformat the title to follow the required format: '[type] solana-dex-trades - move dex trades implementations to factory pattern' or similar.
Description check	⚠️ Warning	The pull request has no description provided, missing all required context about the changes.	Add a detailed pull request description explaining the refactoring rationale, how the factory pattern improves the codebase, and which dex adapters are affected.
Version 2 Required	⚠️ Warning	New adapters (scorch, whalestreet, jupiterz) created via duneSolanaDexTrades factory function lack version: 2 property required for new adapters.	Update duneSolanaDexTrades function in helpers/duneSolanaDex.ts to include version: 2 in returned adapter objects.
Breakdown Methodology Check	❓ Inconclusive	Unable to execute shell commands to verify adapter file structure and git history	Manual verification of adapter files and git history is required to assess the code changes

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Income Statement Compliance	✅ Passed	The PR removes volume adapters (aquifer, goonfi, launchlab) that return dailyVolume, not fees-related metrics. These are DEX adapters, not fees adapters, so the Income Statement compliance check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch solana-dex-trades

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}