Feature/default geomlist for mesh2d_get_mesh_boundaries as_polygons()
#223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veenstrajelmer
changed the title
veenstrajelmer
changed the title
mesh2d_get_mesh_boundaries as_polygons()
veenstrajelmer
deleted the
feature/default-geomlist-for-mesh2d_get_mesh_boundaries_as_polygons2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreasbuykx, I am setting a default for an argument you added in https://github.com/Deltares/MeshKernelPy/pull/212/files. Adding this non-optional argument was I think an unintended breaking API change.
Duplicate of #218, but this one has a proper branch name.