Issue #598 layered hfb error #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not more than 1 layer assigned to LayeredHFB. Also remove unused validation to_mf6_pkg.
JoerivanEngelen
changed the base branch from
master
to
imod5_converter_feature_branch
luitjansl
reviewed
Jun 27, 2024
Contributor
luitjansl
left a comment
luitjansl
left a comment
There was a problem hiding this comment.
looks good, some comments
imod/mf6/hfb.py
Outdated
| compound_dataframe = pd.concat(dataframe_ls, ignore_index=True) | ||
|
|
||
| return LayeredHorizontalFlowBarrierResistance(compound_dataframe) | ||
| return cls(compound_dataframe) |
Contributor
There was a problem hiding this comment.
there is also a "LayeredHorizontalFlowBarrierHydraulicCharacteristic".
Should the changes in this PR also be applied there?
Contributor
Author
There was a problem hiding this comment.
I think not. The hydraulic characteristic is a MODFLOW 6 concept: it is the inverse of the resistance. In the end, both the Resistance as well as the HydraulicCharacteristic variant are converted to a hydraulic characteristic for the Modflow6 HFB package. iMOD5 only allows you to specify a hfb with a resistance, so I don't see a real use case for adding a from_imod5_data method to the HydraulicCharacteristic class.
luitjansl
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598
Description
There was some confusion (also by me) about the use of the
LayeredHorizontalFlowBarrierclasses, so @HendrikKok explained me they were intended for single layers. I therefore changed the following to clarify:SingleLayerHorizontalFlowBarrierclassesValidationErrorif multiple layers are added to datasetThis means multiple SingleLayerHorizontalFlowBarrier need to be added to GroundwaterFlowModel object, whereas MODFLOW 6 only accepts one single HFB. So these have to be merged together. I think the best opportunity for this is to merge the low level
Mf6HorizontalFlowBarrierobjects.Checklist
Issue #nr, e.g.Issue #737