-
Notifications
You must be signed in to change notification settings - Fork 6
Issue #1137 update well from imod5 data #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoerivanEngelen
merged 84 commits into
issue_#1116_fix_imod5_well_import
from
issue_#1137_update_well_from_imod5_data
Aug 14, 2024
Merged
Issue #1137 update well from imod5 data #1147
JoerivanEngelen
merged 84 commits into
issue_#1116_fix_imod5_well_import
from
issue_#1137_update_well_from_imod5_data
Aug 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y id and convert layer list to array in depth info validation.
…ghtly alters test result
luitjansl
approved these changes
Aug 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Fixes #1137
Description
Updates
from_imod5_datato accept data ofopen_projectfile_datain new formRemove
imod.formats.prj.disv_conversionas it is not used anymore, and all functionality in that is now covered by Simulation.from_imod5_data.Ensure all well data is returned with column name "filt_top" and "filt_bot" (not "top" and "bottom"). We might be able to make this more consistent with the
mf6module by naming it toscreen_topandscreen_bottom?Refactor the
from_imod5_datato generalize this into GridAgnosticWell base class, reducing code duplication.For this, add
_imod5_depth_colnamesand_depth_colnamesattributesOnly resample timeseries when loading ipf with associated timeseries
Set unassociated wells when not specified in projectfile on requested timestamp to zero
Associated wells are forward filled in this case
Associated wells are validated for overlapping definitions with different additions, multiplications or same associated wells defined to two layers
Add extra test cases to
imod/tests/test_formats/test_prj_wel.pyUse years in time domain of timeseries associated to ipfs in cases in
imod/tests/test_formats/test_prj_wel.pyAdd tests to load from_imod5_data with times within and outside well time range.
Checklist
Issue #nr, e.g.Issue #737