Conversation
| @@ -0,0 +1,5 @@ | |||
| package ChainOfRes | |||
Collaborator
There was a problem hiding this comment.
ну ты помнишь по-поводу нейминга пакетов
| return true | ||
| } | ||
|
|
||
| // NewHandler ... |
| return true | ||
| } | ||
|
|
||
| // NewHandler ... |
| return &Default{} | ||
| } | ||
| return &doctorB{next: next} | ||
| } |
Collaborator
There was a problem hiding this comment.
выровняй скобки по проекту и т.д. ctrl+alt+L
| return true | ||
| } | ||
|
|
||
| // NewHandler ... |
Collaborator
There was a problem hiding this comment.
да блин, серьезно?
| Right *TreeNode | ||
| } | ||
|
|
||
| func mergeTrees(t1 *TreeNode, t2 *TreeNode) *TreeNode { |
| if t2 == nil{ | ||
| return t1 | ||
| } | ||
| t3 := TreeNode{} |
Collaborator
There was a problem hiding this comment.
var t3 TreeNode ??
| @@ -0,0 +1,5 @@ | |||
| package chainOfRes | |||
|
|
|||
| type Handler interface { | |||
Collaborator
There was a problem hiding this comment.
ну в общем ты помнишь
| type Default struct { | ||
| } | ||
|
|
||
| //Treat ... |
| import "math/rand" | ||
|
|
||
| // Q ... | ||
| type Q interface { |
Collaborator
There was a problem hiding this comment.
вот очень информативное название интерфейса и как с ним жить?
дальнейшие фабрики просто вырывают мозг
| MergeTrees(t1, t2 Creater) Creater | ||
| } | ||
|
|
||
| type obj struct { |
Collaborator
There was a problem hiding this comment.
может тоже стоит назвать структура handler?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.