Use system zlib instead of bundled.#137
Conversation
|
CI scripts and build instructions will need updated to install zlib |
9dacefe to
2bbf7ec
Compare
|
CI and build instructions updated. |
|
Better to use vcpkg to install required dependencies. It has native cmake integration via toolchain files and can build zlib statically on request. |
|
Forgot about Mac and Windows. |
5f1bc5c to
6d7a222
Compare
dd42a19 to
28dc999
Compare
|
Now the vcpkg issues are resolved. In github actions the vcpkg path is hardcoded since the VCPKG_ROOT envvar isn't set. Otherwise it uses VCPKG_ROOT. |
|
I'm being nit-picky here but could you please update README build instructions for Windows users to include VCPKG please ? @Arcnor can confirm but after that I think we're ready to merge :) |
|
Yeah, it will be great, because this PR introduced extra steps to build the project. You can just mention the need to define |
|
Now there is no more extra github actions step, vcpkg has been included in the readme. |
|
Thanks @Nakhr11n and sorry for all the requests, if you fix the conflict we can just merge this :) |
|
Conflicts fixed. Thank you for the feedback :) |
Use system zlib instead of bundled.
It's unnecessary to keep zlib in the project files.
Better to link against system zlib, which is probably more up to date.
If we really want to link statically, I would suggest using CMake ExternalProject to do so.