Skip to content

Remove libGLU references.#246

Merged
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
icculus:ryan-remove-glu
May 1, 2024
Merged

Remove libGLU references.#246
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
icculus:ryan-remove-glu

Conversation

@icculus
Copy link
Contributor

@icculus icculus commented Apr 30, 2024

The game doesn't actually use GLU (just OpenGL), so this can go.

The game doesn't actually use GLU (just OpenGL), so this can go.
@Lgt2x
Copy link
Member

Lgt2x commented Apr 30, 2024

D3Launch.cpp still mentions Glu32.dll in some functions (it's in legacy/) and Soft/HardwareOpenGL.cpp still import Glu.h, should we remove those as well ?

@icculus
Copy link
Contributor Author

icculus commented Apr 30, 2024

I didn't touch legacy because I wasn't sure what the rules are with that, but I'm happy to make changes!

GLU.h in HardwareOpenGL.cpp (and all of SoftwareOpenGL.cpp) went away when #244 was merged.

@Lgt2x
Copy link
Member

Lgt2x commented May 1, 2024

I didn't touch legacy because I wasn't sure what the rules are with that, but I'm happy to make changes!

GLU.h in HardwareOpenGL.cpp (and all of SoftwareOpenGL.cpp) went away when #244 was merged.

Indeed, the branch I was looking at was not rebase. all good !

@Lgt2x Lgt2x merged commit eb4cf2f into DescentDevelopers:main May 1, 2024
@icculus icculus deleted the ryan-remove-glu branch May 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants