Unify and cleanup sound related code into single sndlib module#374
Merged
Lgt2x merged 7 commits intoDescentDevelopers:mainfrom May 22, 2024
Merged
Unify and cleanup sound related code into single sndlib module#374Lgt2x merged 7 commits intoDescentDevelopers:mainfrom
Lgt2x merged 7 commits intoDescentDevelopers:mainfrom
Conversation
winterheart
force-pushed
the
sndlib
branch
2 times, most recently
from
99d8755 to
749a783
Compare
Collaborator
|
Tested artifact in windows and sound works as expected both in movies and in levels. |
Consolidate all sound related code into one module.
Properly include and reuse produced static lib in other components.
Moving common macros into ssl_lib.h
Split linux geometry class implementation into own file, rename directx geometry.cpp to ds3dgeometry.cpp
Minor fixes and enhancements.
Lgt2x
approved these changes
May 22, 2024
| @@ -24,4 +24,6 @@ set(CPPS | |||
| add_library(manage STATIC ${HEADERS} ${CPPS}) | |||
Member
There was a problem hiding this comment.
this lib is really badly named, maybe a good target to split up next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Unify and cleanup sound related code into sndlib module. Update linux part to use SDL2 function calls instead of legacy SDL1.
Currently there two independent sound engines - sndlib and mvelib (played only on MVE cutscenes). This is major preparation before unify MVE sound related code to use single sndlib as sound back-end.
Related Issues
Related to #289
Screenshots (if applicable)
Checklist
Additional Comments