Remove ncurses usage dependency#407
Merged
Lgt2x merged 2 commits intoDescentDevelopers:mainfrom Jun 2, 2024
Merged
Conversation
This type of console is enabled only with `-svgalib` and `-dedicated` options. Since there no svgalib direct support (which is pretty old and too specific to Linux tech), it's better completely remove this code for simplicity and reducing external dependencies. Removed `-svgalib` option as unused now.
20 tasks
Lgt2x
reviewed
Jun 1, 2024
Unify all commands into function interface, which simplifies code.
winterheart
force-pushed
the
remove-ncurses
branch
from
cceea4a to
09823f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Remove ncurses-based type of console, which is enabled only with
-svgaliband-dedicatedoptions. Since there no svgalib direct support (which is pretty old and too specific to Linux tech), it's better completely remove this code for simplicity and reducing external dependencies.Removed
-svgaliboption as unused now.Related Issues
Fixes #404.
Screenshots (if applicable)
Checklist
Additional Comments