Skip to content

Remove redundant GetMultiCDPath()#455

Merged
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
winterheart:remove-getmultcdpath
Jun 24, 2024
Merged

Remove redundant GetMultiCDPath()#455
Lgt2x merged 1 commit intoDescentDevelopers:mainfrom
winterheart:remove-getmultcdpath

Conversation

@winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Function GetMultiCDPath() was used to determine location of files placed on CD/DVD. Since CD/DVD support was removed, this function is now has no use.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

This function was used to determine location of files placed on CD/DVD. Since CD/DVD support was removed, this function is now has no use.
@Lgt2x Lgt2x added the cleanup Code cleanup label Jun 24, 2024
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good, I was hesitant to do it in #452 because you updated this function recently, but it makes sense now :)

@Lgt2x Lgt2x merged commit c5d5037 into DescentDevelopers:main Jun 24, 2024
@winterheart winterheart deleted the remove-getmultcdpath branch August 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants