Merged
Conversation
Fixes some issues when sound buffer get exhausted before refilling.
Change mveaudio_process() to use sample size defined by stream.
Lgt2x
approved these changes
Jul 14, 2024
Member
Lgt2x
left a comment
There was a problem hiding this comment.
works great on Linux. Will test Windows debug
Member
|
Movies also run flawlessly on Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR changes MVE library to use "push" model of filling sound buffer by switching to
SDL_QueueAudio()instead of "pull" by using SDLAudioCallback. This fixes some issues when the sound buffer gets exhausted before refilling and delays on slow Debug environments.Additional fix addressed to correct sample_size on
mveaudio_process()with 8-bit samples (though they don't used in D3).Related Issues
Closes #490.
Screenshots (if applicable)
Checklist
Additional Comments