Fixes and enhancements to CMake build system#54
Merged
Arcnor merged 1 commit intoDescentDevelopers:mainfrom Apr 18, 2024
Merged
Fixes and enhancements to CMake build system#54Arcnor merged 1 commit intoDescentDevelopers:mainfrom
Arcnor merged 1 commit intoDescentDevelopers:mainfrom
Conversation
Updated compatibility level to 3.19. Set C++17 globally for all platforms. Removed hardcoded compiler and optimisation flags. Adjusted dependencies and libraries linking. Reworked script building and hog creation.
Arcnor
reviewed
Apr 18, 2024
| ADD_CUSTOM_COMMAND( | ||
| TARGET ${SCRIPT} | ||
| POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E copy $<TARGET_FILE:${SCRIPT}> "${CMAKE_SOURCE_DIR}/scripts/data/linuxfullhog/" |
Contributor
There was a problem hiding this comment.
I think we'll have to revisit this, copying into the source directory is not very clean, this should probably be the binary one, then some extra code to deal with whatever needs to happen to those files later (install them?)
Collaborator
Author
There was a problem hiding this comment.
Yeah, I was thinking on it. Will rework this some day.
Lgt2x
reviewed
Apr 18, 2024
| SET(CMAKE_CXX_EXTENSIONS OFF) | ||
| SET(CMAKE_POSITION_INDEPENDENT_CODE ON) | ||
|
|
||
| SET (D3_GAMEDIR "~/Descent3/") |
Member
There was a problem hiding this comment.
D3_GAMEDIR should be a cache variable set by the user
JeodC
pushed a commit
that referenced
this pull request
Apr 28, 2024
Fixes and enhancements to CMake build system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated compatibility level to 3.19. Set C++17 globally for all platforms. Removed hardcoded compiler and optimisation flags. Adjusted dependencies and libraries linking.
Reworked script building and hog creation.