Skip to content

Update detsys-ts: Merge pull request #107 from DeterminateSystems/dependabot/github_actions/actions-deps-a331d3ec2d#108

Merged
lucperkins merged 7 commits intoDeterminateSystems:mainfrom
detsys-pr-bot:detsys-ts-update-e439a01995ac029e7481a75c4661a7f60eeb8b19
Sep 16, 2025
Merged

Update detsys-ts: Merge pull request #107 from DeterminateSystems/dependabot/github_actions/actions-deps-a331d3ec2d#108
lucperkins merged 7 commits intoDeterminateSystems:mainfrom
detsys-pr-bot:detsys-ts-update-e439a01995ac029e7481a75c4661a7f60eeb8b19

Conversation

@detsys-pr-bot
Copy link
Copy Markdown

@detsys-pr-bot detsys-pr-bot commented Aug 25, 2025

Bump detsys-ts to the latest HEAD and regenerate application bundle.

Summary by CodeRabbit

  • Chores
    • Updated development type definitions to a newer patch release for improved tooling accuracy.
    • Updated CI test invocation to use the repository's dev environment command.
    • Added an ignore rule for local environment files.
    • Reworked developer environment inputs: reduced supported build platforms and introduced per-platform formatting tooling in dev shells.
    • No user-facing changes; app behavior remains unchanged.

…om DeterminateSystems/dependabot/github_actions/actions-deps-a331d3ec2d` (`e439a01995ac029e7481a75c4661a7f60eeb8b19`)
detsys-pr-bot pushed a commit to detsys-pr-bot/flakehub-mirror that referenced this pull request Sep 3, 2025
…e nix store version (DeterminateSystems#108)` (`c7303495f43d348cac78091ef434443b1ef22485`)
grahamc added a commit that referenced this pull request Sep 3, 2025
…43d348cac78091ef434443b1ef22485

Update `detsys-ts`: Capture the version of Nix in addition to the nix store version (#108)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates include a devDependency bump in package.json, a CI command tweak, a .gitignore addition for .direnv, and a refactor of flake.nix to remove flake-schemas, expose a per-system formatter, reduce supported systems, and rewire devShells to use the new formatter attributes.

Changes

Cohort / File(s) Summary
Dev dependency bump
package.json
Update @types/node from ^20.19.13 to ^20.19.15 (patch-level TypeScript typings).
CI command change
.github/workflows/ci.yml
Change test step to run nix develop --command pnpm run test instead of nix develop --command pnpm test.
Ignored files
.gitignore
Add .direnv to git ignore rules.
Flake refactor & outputs
flake.nix
Remove flake-schemas input; change outputs signature to outputs = { self, ... }@inputs; add formatter as per-system attribute computed via forEachSupportedSystem ({ pkgs }: pkgs.nixfmt-rfc-style); reduce supportedSystems to ["x86_64-linux","aarch64-darwin"]; update forEachSupportedSystem and devShells to import inputs.nixpkgs per system and include self.formatter.${system} in devShell packages.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant User
    participant Flake as flake.nix (outputs)
    participant Inputs as inputs.nixpkgs
    participant System as per-system attrs

    rect rgb(230,245,255)
    note over Flake,Inputs: New flow computes per-system formatter from inputs.nixpkgs
    User->>Flake: request outputs
    Flake->>Inputs: import inputs.nixpkgs { system }
    Inputs->>System: provide pkgs
    System->>Flake: pkgs.nixfmt-rfc-style -> formatter.${system}
    Flake->>Flake: assemble devShells including self.formatter.${system}
    Flake->>User: return outputs (formatter, devShells, ...)
    end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

I hop through flakes and tiny bumps,
I nudge a devtype, change CI stumps.
I tuck .direnv out of sight,
And weave per-system formatters right.
A rabbit's tweak — small, tidy, bright. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description documents the upstream bump and regenerated bundle with source references, but it does not follow the repository's required template: it is missing the "The project's license is:" line and the three checklist items, so it fails to meet the repository's mandatory description structure. Please update the PR description to include the repository template's required sections by adding the project's license line and completing the three checklist items (license permissiveness, publish status, and release/mirror information); you may keep the existing upstream bump details and diff links after those required fields are added.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly identifies the primary change—updating detsys-ts—and references the upstream PR, so it accurately reflects the changes in the PR summary and raw diff; it is somewhat verbose because it includes merge metadata but is not misleading.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f29397 and acf8968.

⛔ Files ignored due to path filters (3)
  • dist/index.js is excluded by !**/dist/**
  • flake.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .github/workflows/ci.yml (1 hunks)
  • .gitignore (1 hunks)
  • flake.nix (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucperkins lucperkins disabled auto-merge September 16, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants