Skip to content

Update deps, go to node24#239

Merged
grahamc merged 7 commits intomainfrom
push-uxsuokmopvzm
Mar 25, 2026
Merged

Update deps, go to node24#239
grahamc merged 7 commits intomainfrom
push-uxsuokmopvzm

Conversation

@grahamc
Copy link
Copy Markdown
Member

@grahamc grahamc commented Mar 25, 2026

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

  • Chores

    • CI runners moved to the latest Ubuntu runner
    • Action runtime updated to Node.js 24
    • Core action dependencies upgraded to newer major versions
    • Checkout action reference updated to v6
  • Documentation

    • Workflow examples updated to reflect the newer checkout action version

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1c09aa0e-3810-4d12-a543-6dcd1a100712

📥 Commits

Reviewing files that changed from the base of the PR and between e900a25 and efb34bc.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

CI/workflow and action runtime/dependencies were updated: actions/checkout references bumped to v6, CI jobs switched from ubuntu-22.04ubuntu-latest, action runtime set to Node 24, and @actions/* packages upgraded. No job logic or action entrypoints changed.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/ci.yml
Updated job runners from ubuntu-22.04ubuntu-latest for multiple jobs and replaced actions/checkout@v4actions/checkout@v6. No other job logic, dependencies, strategies, or permissions changed.
Action metadata
action.yml
Changed action runtime runs.using from node20node24; runs.main/runs.post unchanged.
Documentation
README.md
Workflow examples updated to use actions/checkout@v6 (no other changes to examples).
Dependencies
package.json
Bumped GitHub Actions libraries: @actions/core ^1.11.1 → ^3.0.0, @actions/exec ^1.1.1 → ^3.0.0, @actions/github ^6.0.1 → ^9.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through workflows, tidy and spry,
Checkout v6 gave a gleam to my eye,
Node twenty-four now hums in the den,
Packages updated — I danced again! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update deps, go to node24' clearly and concisely summarizes the main changes: dependency updates and migration to Node.js 24, which aligns with all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch push-uxsuokmopvzm

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
action.yml (1)

153-153: Update build target to match Node.js 24 runtime.

The action runtime has been updated to node24, but the build configuration in tsup.config.ts still targets Node 20 (target: "node20" at line 8). While Node 20 code is generally forward-compatible with Node 24, the build target should be updated to match the runtime for optimal compatibility and to enable any Node 24-specific optimizations.

♻️ Update tsup.config.ts build target

Apply this change to tsup.config.ts:

 export default defineConfig({
   name,
   entry: ["src/index.ts"],
   format: ["esm"],
-  target: "node20",
+  target: "node24",
   bundle: true,
   splitting: false,
   clean: true,
   dts: {
     resolve: true,
   },
 });
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@action.yml` at line 153, Update the tsup build target to match the action
runtime by changing the target value in tsup.config.ts from "node20" to
"node24": open tsup.config.ts, locate the exported config where target: "node20"
is defined (e.g., inside the defineConfig/export default object) and replace it
with target: "node24" so the bundle is built for Node.js 24.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@action.yml`:
- Line 153: Update the tsup build target to match the action runtime by changing
the target value in tsup.config.ts from "node20" to "node24": open
tsup.config.ts, locate the exported config where target: "node20" is defined
(e.g., inside the defineConfig/export default object) and replace it with
target: "node24" so the bundle is built for Node.js 24.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 005d9a21-a3d0-44c1-80f8-b8099a04e14c

📥 Commits

Reviewing files that changed from the base of the PR and between e02dcf8 and 6a384b4.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • README.md
  • action.yml
  • package.json

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Line 167: The workflow uses an invalid runner label in the install-no-id-token
job: change the runs-on value from "ubuntu-late" to a valid GitHub-hosted runner
(e.g., "ubuntu-latest") so the install-no-id-token job can be scheduled and
allow the dependent tests job to run; locate the runs-on entry in the ci.yml job
definition and update its label accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fbad61e-5ffe-4a90-851f-dabd188b473b

📥 Commits

Reviewing files that changed from the base of the PR and between 6a384b4 and e900a25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@grahamc grahamc merged commit ef8a148 into main Mar 25, 2026
12 checks passed
@grahamc grahamc deleted the push-uxsuokmopvzm branch March 25, 2026 14:12
@lucperkins lucperkins mentioned this pull request Mar 29, 2026
@coderabbitai coderabbitai bot mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants