Skip to content

Wait on verify to complete before allowing tests to continue#38

Merged
andrewspinks merged 1 commit intoDiUS:masterfrom
stitchfix:master
May 1, 2018
Merged

Wait on verify to complete before allowing tests to continue#38
andrewspinks merged 1 commit intoDiUS:masterfrom
stitchfix:master

Conversation

@epv44
Copy link
Copy Markdown
Contributor

@epv44 epv44 commented May 1, 2018

While using pact-consumer-swift we have seen flakey results in our pact tests. Upon investigation, it appears that:

The call to pactVerificationService.verify asynchronously communicates with the server, and the run function will return before it's done. If a subsequent spec comes along and clears the interactions from the server, it will cause a race.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 1, 2018

Codecov Report

Merging #38 into master will increase coverage by 0.04%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   91.12%   91.17%   +0.04%     
==========================================
  Files           6        6              
  Lines         372      374       +2     
==========================================
+ Hits          339      341       +2     
  Misses         33       33

@andrewspinks andrewspinks merged commit 6749fdc into DiUS:master May 1, 2018
@andrewspinks
Copy link
Copy Markdown
Contributor

@epv44 Interesting! Thanks!

@dexterteng3
Copy link
Copy Markdown

Hello @andrewspinks , we were wondering when this patch might be released? Thanks!

@andrewspinks
Copy link
Copy Markdown
Contributor

@dexterteng3 Apologies, I forgot about this. 0.5.2 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants