LX-293 Check out version of mapbox-gl-draw with fix for touch screens#298
Merged
rogup merged 1 commit intodevelopmentfrom Mar 6, 2024
Merged
LX-293 Check out version of mapbox-gl-draw with fix for touch screens#298rogup merged 1 commit intodevelopmentfrom
rogup merged 1 commit intodevelopmentfrom
Conversation
Collaborator
Author
|
@ms0ur1s since we don't have as long to pair, thought I would just push the proposed changes I mentioned for you to look over I have no idea if this will break other functionality, so probably needs a bit of general testing with drawing lines/polygons and messing with the boundary layer. But it seems to fix the problem when I test it using the mobile emulator in Google Chrome Inspect tools :) |
Contributor
Collaborator
|
@lin-d-hop, I've just tested it locally, as well, on a mobile simulator and seems to work. I think it can go into review. |
Contributor
Collaborator
Contributor
Collaborator
Author
|
Not sure, I've just merged it |
Contributor
|
This is great! Nice work team! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #293
Tapping on drawn polygons and the property boundary layer doesn't work on touch screens.
We're hitting the problem described here mapbox/mapbox-gl-draw#869
The issue was fixed by mapbox/mapbox-gl-draw#1146 in this commit mapbox/mapbox-gl-draw@84e35b7
However, they reverted the fix because it broke editing of drawings on mobile mapbox/mapbox-gl-draw#1158
But we don't allow drawings on mobile anyway, so this doesn't matter to us.
So we will use this specific commit of the mapbox-gl-draw repo, and we can wait on a proper fix before we upgrade the package again
What should we test?
Release notes
Deployment notes
Documentation updates