Fake mailbox queries fail when adding any query clauses#87
Merged
stevebauman merged 3 commits intoDirectoryTree:masterfrom Jun 19, 2025
sertxudev:sertxudev/failing-test
Merged
Fake mailbox queries fail when adding any query clauses#87stevebauman merged 3 commits intoDirectoryTree:masterfrom sertxudev:sertxudev/failing-test
stevebauman merged 3 commits intoDirectoryTree:masterfrom
sertxudev:sertxudev/failing-test
Conversation
…o be shared to FakeMessageQuery
stevebauman
changed the title
Member
|
Hi @sertxudev, thanks! This was a bug. However to note: the fake mailbox should be populated with whatever messages that should be returned by any query you're executing. It should not perform any filtering in PHP. Otherwise, we'd have to replicate all IMAP server search functionality in PHP. |
Member
|
Patch is out in v1.15.2. Run |
Contributor
Author
|
Thanks @stevebauman , no problem if there's no filtering on the fake mailbox as that should be handled by the IMAP server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I've found a bug, using
$folder->messages()->where('Unseen')works, but if I fake it it doesn't work.Idk if this should work or if there's another way to test it out.