Skip to content

feat: Milestone 1 - CRD Foundation for Manager-Worker model#106

Closed
josephaw1022 wants to merge 2 commits intomainfrom
feat/milestone-1-crd-foundation
Closed

feat: Milestone 1 - CRD Foundation for Manager-Worker model#106
josephaw1022 wants to merge 2 commits intomainfrom
feat/milestone-1-crd-foundation

Conversation

@josephaw1022
Copy link
Copy Markdown
Collaborator

@josephaw1022 josephaw1022 commented Mar 21, 2026

This PR implements Milestone 1 of the Manager-Worker architecture proposal as described in issue #86.

Key changes:

  • Introduced shared IdentitySpec for multiple authentication types (SqlLogin, WorkloadIdentity, AppRegistration).
  • Updated SQLServer and ExternalSQLServer to include the Identity spec.
  • Refactored existing controllers and finalizers to use Identity.SecretName.
  • Introduced ExternalDatabase CRD for database-level identity isolation (required for Azure SQL).
  • Refactored Helm templates to use mustMerge/deepCopy to avoid duplicate keys.
  • Standardized Kubernetes labels in Helm chart using selectorLabels/commonLabels.
  • Updated C# unit tests (TestDataBuilder) to match the new CRD structure.
  • Switched to LF line endings in .editorconfig and standardized all files to fix CI formatting failures.

Ref: #86

@josephaw1022 josephaw1022 force-pushed the feat/milestone-1-crd-foundation branch from c36754d to 834d86b Compare March 21, 2026 05:11
@josephaw1022 josephaw1022 deleted the feat/milestone-1-crd-foundation branch March 29, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant