Collect incremental state without passing compilation to output stage

[sharwell]

No description provided.

[sharwell]

@chsienki this is IncrementalValuesProvider<IAssemblySymbol>, which should be efficient provided the IAssemblySymbol for a metadata reference is carried forward from one compilation to the next. Do you know if this is true for the IDE and/or command line?

[chsienki]

Yes, they should be carried forward. There is also context.MetadataReferences which provides the same thing. You don't get the IAssemblySymbol directly, but if you new up a compilation with the reference you can retrieve it, and the input will then never change unless the user adjusts references.

[sharwell]

I'll switch over to context.MetadataReferences after 4.2.0 is released (this is the version that corrects the signature for this property).

[sharwell]

@chsienki is there a straightforward way to have a properly equatable list of strings in a record, without having to implement custom equality?

[sharwell]

@chsienki is there a straightforward way to have a properly equatable dictionary in a record, without having to implement custom equality?

[codecov]

Codecov Report

Merging #3452 (253d408) into master (6cd35b5) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
- Coverage   93.23%   92.95%   -0.28%     
==========================================
  Files        1063     1063              
  Lines      113033   136647   +23614     
  Branches     3980     7071    +3091     
==========================================
+ Hits       105383   127020   +21637     
- Misses       6630     8421    +1791     
- Partials     1020     1206     +186     

[manfred-brands]

Could you reference Microsoft.Bcl.HashCode instead?

[sharwell]

I prefer to avoid dependencies in the source generator, since it makes build integration much more complex.