feat(process): 实现信号备用栈的拷贝逻辑#1363
Merged
fslongjin merged 1 commit intoDragonOS-Community:masterfrom Nov 12, 2025
Merged
Conversation
Member
fslongjin
commented
Nov 12, 2025
- 在进程创建流程中拷贝信号备用栈,确保子进程正确继承父进程的sigaltstack 设置
- 从测试黑名单中移除ForkTest.SigAltStack
- 在进程创建流程中拷贝信号备用栈,确保子进程正确继承父进程的sigaltstack 设置 - 从测试黑名单中移除ForkTest.SigAltStack Signed-off-by: longjin <longjin@DragonOS.org>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the copying of signal alternate stack (sigaltstack) during process creation to ensure child processes correctly inherit their parent's sigaltstack settings. The key change removes the ForkTest.SigAltStack test from the blocklist after implementing this functionality.
- Adds a new
copy_sigaltstack()function that handles the proper inheritance semantics for sigaltstack during fork/clone operations - Integrates the sigaltstack copying into the process creation flow in the
copy_info()function - Removes previously failing tests from blocklists (
ForkTest.SigAltStack,Waiters/WaitSpecificChildTest.CloneThread/*, andWaiters/WaitSpecificChildTest.ForkWCLONE/*)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kernel/src/process/fork.rs | Implements copy_sigaltstack() function and integrates it into the process creation workflow |
| user/apps/tests/syscall/gvisor/blocklists/fork_test | Removes ForkTest.SigAltStack from the blocklist |
| user/apps/tests/syscall/gvisor/blocklists/wait_test | Removes Waiters/WaitSpecificChildTest.CloneThread/* and Waiters/WaitSpecificChildTest.ForkWCLONE/* from blocklist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.