refactor(smp): 将smp模块的系统调用适配syscall table#1367
Merged
fslongjin merged 1 commit intoDragonOS-Community:masterfrom Nov 12, 2025
Merged
refactor(smp): 将smp模块的系统调用适配syscall table#1367fslongjin merged 1 commit intoDragonOS-Community:masterfrom
fslongjin merged 1 commit intoDragonOS-Community:masterfrom
Conversation
Signed-off-by: longjin <longjin@DragonOS.org>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SMP module's system call to adapt to the syscall table architecture. The main change is migrating the sched_getaffinity system call from the old monolithic syscall handler to a new modular syscall table structure.
- Removed inline
SYS_SCHED_GETAFFINITYhandling from the main syscall dispatcher - Created a new dedicated syscall handler struct implementing the
Syscalltrait - Added proper bounds checking to prevent buffer overflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kernel/src/syscall/mod.rs | Removed inline SYS_SCHED_GETAFFINITY handling from the main syscall match statement |
| kernel/src/smp/syscall/sys_sched_getaffinity.rs | Added new modular syscall handler implementing the Syscall trait with proper bounds checking |
| kernel/src/smp/syscall/mod.rs | Added module declaration for the new syscall handler |
| kernel/src/smp/syscall.rs | Removed old implementation that lacked bounds checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.