fix(vfs): 修复syncfs系统调用中文件描述符验证问题#1369
Merged
fslongjin merged 1 commit intoDragonOS-Community:masterfrom Nov 12, 2025
Merged
Conversation
Member
fslongjin
commented
Nov 12, 2025
fslongjin
commented
- 在syncfs系统调用中添加文件描述符验证逻辑
- 检查文件描述符是否存在以及是否以O_PATH模式打开
- 当文件描述符无效或为O_PATH模式时返回EBADF错误
- 添加sync_test到gvisor测试白名单中
- 在syncfs系统调用中添加文件描述符验证逻辑 - 检查文件描述符是否存在以及是否以O_PATH模式打开 - 当文件描述符无效或为O_PATH模式时返回EBADF错误 - 添加sync_test到gvisor测试白名单中 Signed-off-by: longjin <longjin@DragonOS.org>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a file descriptor validation issue in the syncfs system call by adding proper validation logic to check if the fd exists and whether it was opened with O_PATH mode. When the file descriptor is invalid or opened with O_PATH, the syscall now correctly returns EBADF error.
- Added file descriptor existence validation in syncfs syscall
- Added O_PATH mode check to reject O_PATH file descriptors
- Enabled sync_test in the gvisor test whitelist
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kernel/src/filesystem/vfs/syscall/sys_sync.rs | Added fd validation logic including O_PATH check and proper error handling |
| user/apps/tests/syscall/gvisor/whitelist.txt | Added sync_test to enable testing of the sync/syncfs functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.