fix(pipe): 修复阻塞模式下写端唤醒的竞态条件#1529
Merged
fslongjin merged 1 commit intoDragonOS-Community:masterfrom Dec 21, 2025
Merged
Conversation
- 在阻塞模式下先增加 writer 计数再等待读端,避免竞态条件 - 在增加 writer 计数后立即唤醒等待的读者 - 处理信号中断时回滚 writer 计数 - 确保非阻塞模式下也正确唤醒读者 Signed-off-by: longjin <longjin@DragonOS.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题现象
在 DragonOS 中,
FifoTest.FifoTruncNoOp测试用例多次运行时可能会出现卡死现象。该测试用例涉及 FIFO(命名管道)的创建和打开操作。测试用例关键流程
测试用例
fifo.cc的执行流程:O_RDONLY模式打开 FIFO(会阻塞直到有写端打开)O_WRONLY | O_TRUNC模式打开 FIFO(会阻塞直到有读端打开)死锁时序分析
问题根源
这是一个典型的 TOCTOU (Time-of-check to time-of-use) 竞态条件:
has_reader,后增加writer计数writer计数增加太晚,导致读端检查时看不到写端存在修复后的正确时序
关键修复点总结
writer += 1移到等待之前