Merged
Conversation
Contributor
|
r? @fslongjin dragonosbot has assigned @fslongjin. Use |
dragonosbot
added
O-x86_64
Member
|
这个pr目前有冲突哈哈 @Jomocool |
Member
|
issue: #534 |
fslongjin
requested changes
Apr 6, 2024
kernel/src/ipc/shm.rs
Outdated
| /// 最后一次连接的时间 | ||
| shm_atim: i64, | ||
| /// 最后一次断开连接的时间 | ||
| shm_dtim: i64, |
Collaborator
Author
There was a problem hiding this comment.
我觉得TimeSpec应该会更好一点，因为Linux用户程序获取这些时间的好像是ns级别
dragonosbot
added
S-等待作者修改
Member
|
暂时没有看出逻辑上的问题，能否传个测试程序上来？ |
dragonosbot
added
A-fs
Collaborator
Author
|
@dragonosbot review |
Jomocool
commented
Apr 7, 2024
Collaborator
Author
Jomocool
left a comment
Jomocool
left a comment
There was a problem hiding this comment.
测试程序test_shm:
- sender：将信息写入共享内存中然后发送给receiver
- receiver：连接到sender创建的共享内存并读取数据
- info：打印共享内存各种信息
fslongjin
reviewed
Apr 7, 2024
kernel/src/filesystem/devpts/mod.rs
Outdated
| mtime: PosixTimeSpec::default(), | ||
| ctime: PosixTimeSpec::default(), | ||
| file_type: FileType::Dir, | ||
| mode: ModeType::from_bits_truncate(0x777), |
Member
There was a problem hiding this comment.
笑死，我发现这里有个bug，mode应该是0o777而不是0x777
Member
为了跟其他测试程序作区分，我把他改了一下，加上了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.