Support response generators for the endpoint results#1330
Closed
brockallen wants to merge 13 commits intomainfrom
Closed
Support response generators for the endpoint results#1330brockallen wants to merge 13 commits intomainfrom
brockallen wants to merge 13 commits intomainfrom
Conversation
…ftware/IdentityServer into brock/result-generators
Member
Author
|
This PR got borked by rebasing. Will fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
IEndpointResultGenerator<T>type which is designed to render theIEndpointResultobjects that are returned from theIEndpointHandlerin our endpoint routing architecture.Previously the
IEndpointResultwould render themselves, but was difficult for customers to override or change how they did this. Now our built inIEndpointResultclasses use a new base classEndpointResultwhich will resolve aIEndpointResultGenerator<T>from DI to do the rendering. This allows customers to register their ownIEndpointResultGenerator<T>and can change how they are rendered to the HTTP response.This PR is also designed to be backwards compatible with the prior approach, such that any custom
IEndpointResultorIEndpointHandlershould still work the way they used to.Closes: #1129