Skip to content

add support for introspection for refresh tokens#1334

Merged
josephdecock merged 2 commits intomainfrom
brock/introspect-refresh-tokens
Jul 7, 2023
Merged

add support for introspection for refresh tokens#1334
josephdecock merged 2 commits intomainfrom
brock/introspect-refresh-tokens

Conversation

@brockallen
Copy link
Copy Markdown
Member

Closes: #1101

@brockallen brockallen added this to the 7.0 milestone Jun 9, 2023
@brockallen brockallen requested a review from josephdecock June 9, 2023 18:33
@brockallen brockallen added the impact/breaking The fix or change will be a breaking one label Jun 9, 2023
@brockallen
Copy link
Copy Markdown
Member Author

brockallen commented Jun 9, 2023

Some API breaking changes around the introspection request validator. A new context param was created. Might also mean some docs need updating.

{
if (Constants.SupportedTokenTypeHints.Contains(hint))
{
_logger.LogDebug("Token type hint found in request: {tokenTypeHint}", hint);

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
}
else
{
_logger.LogError("Invalid token type hint: {tokenTypeHint}", hint);

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
@brockallen
Copy link
Copy Markdown
Member Author

maybe docs for this in our endpoints section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/breaking The fix or change will be a breaking one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duende IdentityServer does not validate introspection requests for Refresh Tokens

3 participants