Discourage IAuthorizationParametersMessageStore#1462
Merged
brockallen merged 1 commit intomainfrom Nov 7, 2023
Merged
Conversation
PAR is a more robust/standardized approach to get similar benefits
brockallen
approved these changes
Nov 7, 2023
Closed
Member
|
While I'd love to use PAR everywhere instead of passing a bunch of query parameters to the authorize endpoint, it's not really feasible to expect that every client suddenly can switch to using PAR. Our own client applications can be updated over time, but unfortunately, we can't force or control external applications that also use our Duende instance. And because we had some issues with URL's becoming too large, we are using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAR is a more robust/standardized approach to get similar benefits
This PR obsoletes the extension method that registers the default
IAuthorizationParametersMessageStoreas well as theToOptimizedFullDictionarymethod, which is only used when that store is used. There are more types that could in theory be obsoleted - notably theIAuthorizationParametersMessageStoreitself, but that gets used in many places, and would add quite a bit of clutter.This closes #1444