Skip to content

Discourage IAuthorizationParametersMessageStore#1462

Merged
brockallen merged 1 commit intomainfrom
joe/cleanup-validated-authorize-request-extensions
Nov 7, 2023
Merged

Discourage IAuthorizationParametersMessageStore#1462
brockallen merged 1 commit intomainfrom
joe/cleanup-validated-authorize-request-extensions

Conversation

@josephdecock
Copy link
Copy Markdown
Member

PAR is a more robust/standardized approach to get similar benefits

This PR obsoletes the extension method that registers the default IAuthorizationParametersMessageStore as well as the ToOptimizedFullDictionary method, which is only used when that store is used. There are more types that could in theory be obsoleted - notably the IAuthorizationParametersMessageStore itself, but that gets used in many places, and would add quite a bit of clutter.

This closes #1444

PAR is a more robust/standardized approach to get similar benefits
@brockallen brockallen added this to the 7.0.0 milestone Nov 7, 2023
@brockallen brockallen merged commit 8eb790c into main Nov 7, 2023
@brockallen brockallen deleted the joe/cleanup-validated-authorize-request-extensions branch November 7, 2023 17:24
@josephdecock josephdecock added the impact/breaking The fix or change will be a breaking one label Nov 10, 2023
@josephdecock josephdecock mentioned this pull request Nov 10, 2023
@wcabus
Copy link
Copy Markdown
Member

wcabus commented Jan 19, 2024

While I'd love to use PAR everywhere instead of passing a bunch of query parameters to the authorize endpoint, it's not really feasible to expect that every client suddenly can switch to using PAR. Our own client applications can be updated over time, but unfortunately, we can't force or control external applications that also use our Duende instance.

And because we had some issues with URL's becoming too large, we are using the DistributedCacheAuthorizationParametersMessageStore backed by a distributed SQL database cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/breaking The fix or change will be a breaking one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up ValidatedAuthorizeRequest extension methods (ToOptimized...)

3 participants