Skip to content

Enable refresh token reuse by default #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephdecock merged 2 commits into from
Dec 20, 2023
Merged

Enable refresh token reuse by default #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba81e7f
Change some token option defaults
josephdecock Dec 20, 2023
77f3919
Revert operational store default changes
josephdecock Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/IdentityServer/Services/Default/DefaultIssuerNameService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public Task<string> GetCurrentAsync()
// if MTLS is configured with domain like "foo", then the request will be for "foo.acme.com",
// so the issuer we use is from the parent domain (e.g. "acme.com")
//
// Host.Value is used to get unicode hostname, instread of ToUriComponent (aka punycode)
// Host.Value is used to get unicode hostname, instead of ToUriComponent (aka punycode)
origin = request.Scheme + "://" + request.Host.Value.Substring(_options.MutualTls.DomainName.Length + 1);
}
}
Expand Down
11 changes: 9 additions & 2 deletions src/Storage/Models/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,17 @@ public ICollection<string> AllowedGrantTypes
public bool RequirePushedAuthorization { get; set; } = false;

/// <summary>
/// ReUse: the refresh token handle will stay the same when refreshing tokens
/// Specifies if tokens should be rotated when they are used. Defaults to
/// reusable tokens.
/// <para>
/// ReUse: the refresh token handle will stay the same when refreshing
/// tokens
/// </para>
/// <para>
/// OneTime: the refresh token handle will be updated when refreshing tokens
/// </para>
/// </summary>
public TokenUsage RefreshTokenUsage { get; set; } = TokenUsage.OneTimeOnly;
public TokenUsage RefreshTokenUsage { get; set; } = TokenUsage.ReUse;

/// <summary>
/// Specifies whether the access token (and its claims) should be updated on a refresh token request.
Expand Down