Add option for strict validation of assertion audiences#1737
Merged
josephdecock merged 1 commit intomainfrom Jan 28, 2025
Merged
Add option for strict validation of assertion audiences#1737josephdecock merged 1 commit intomainfrom
josephdecock merged 1 commit intomainfrom
Conversation
josephdecock
commented
Jan 27, 2025
identity-server/src/IdentityServer/Validation/Default/PrivateKeyJwtSecretValidator.cs
Outdated
Show resolved
Hide resolved
josephdecock
force-pushed
the
jmdc/strict-aud-validation
branch
from
7d28775 to
5a7c9ee
Compare
Adds a new option that will enforce that the only private_key_jwt audience allowed is the issuer identifier, and not even a wrapping array of a single value.
josephdecock
force-pushed
the
jmdc/strict-aud-validation
branch
from
5a7c9ee to
f50960a
Compare
bhazen
approved these changes
Jan 27, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Dec 1, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option that will enforce that the only private_key_jwt audience allowed is the issuer identifier, and that it is a string - not an array of a single value.
The audience of private key jwts has historically been somewhat open to implementation in various OAuth and OpenId specs. Some specs have said to use the issuer identifier, others the token endpoint or other endpoints, and some say to accept all. However, there is currently an effort from IETF and OpenID foundation to make audience requirements consistent across all specifications, which will be accomplished by only accepting the issuer identifier. The most recent FAPI (financial grade API) specification requires this strict validation, and other specifications are in the process of being updated as well.