Skip to content

Remove assemblyCount from diagnostics #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephdecock merged 1 commit into from
Jun 12, 2025
Merged

Remove assemblyCount from diagnostics #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../IdentityServer/Licensing/V2/Diagnostics/DiagnosticEntries/AssemblyInfoDiagnosticEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public Task WriteAsync(Utf8JsonWriter writer)
var assemblies = GetAssemblyInfo();
writer.WriteStartObject("AssemblyInfo");
writer.WriteString("DotnetVersion", RuntimeInformation.FrameworkDescription);
writer.WriteNumber("AssemblyCount", assemblies.Count);

writer.WriteStartArray("Assemblies");
foreach (var assembly in assemblies.Where(assembly => assembly.GetName().Name != null &&
Expand Down
1 change: 0 additions & 1 deletion ...entityServer.UnitTests/Licensing/v2/DiagnosticEntries/AssemblyInfoDiagnosticEntryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public async Task Should_Write_Assembly_Info()
var result = await DiagnosticEntryTestHelper.WriteEntryToJson(subject);

var assemblyInfo = result.RootElement.GetProperty("AssemblyInfo");
assemblyInfo.GetProperty("AssemblyCount").ValueKind.ShouldBe(JsonValueKind.Number);
var assemblies = assemblyInfo.GetProperty("Assemblies");
assemblies.ValueKind.ShouldBe(JsonValueKind.Array);
var firstEntry = assemblies.EnumerateArray().First();
Expand Down
Loading